Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposer method quick fixes remove all annotations instead of mutually exclusive ones. #540

Open
mrglavas opened this issue Nov 15, 2024 · 1 comment
Open

Disposer method quick fixes remove all annotations instead of mutually exclusive ones. #540

mrglavas opened this issue Nov 15, 2024 · 1 comment

Comments

@mrglavas
Copy link

mrglavas commented Nov 15, 2024 •
edited
Loading

Pull request #511 added a quick fix which removes all three annotations from a parameter when some of the annotations are in conflict. E.g. "@Disposes @Observes @ObservesAsync String name" There should be two quick fixes, one that removes @Disposes and one that removes @Observes and @ObservesAsync.

Current behaviour (screenshots are examples from IntelliJ, but this applies to LSP4Jakarta):

Diagnostic:
image

Quick fix:
image

Pull request #539 temporarily disables these quick fixes until this issue is resolved.
@mrglavas mrglavas changed the title Disposer method quick fix removes all annotations instead of mutually exclusive ones. Disposer method quick fixes remove all annotations instead of mutually exclusive ones. Nov 15, 2024
@TrevCraw
Copy link
Contributor

Once the quick fixes are added correctly, make sure to re-enable the associated unit tests as part of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrglavas @TrevCraw