-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block page redirects and ask user how to proceed #201
Comments
Can you include an example case here? I‘ve lost track of the original concrete case that triggered it. |
Ah, right, thank you! So some redirects, like this one, which uses a On the other hand, we probably can’t handle script-based redirects right now:
|
We could break it into two part. One for the easy redirects, and another for script-based ones. Wondering out loud if either of them is v0.0.2. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions. |
Ugh, this is pretty important and we still haven’t done it. |
When viewing a diff of a page that has client-side redirects, the experience can be pretty confusing. Because we are diffing the page's HTML, you never see the actual comparison. The comparison loads, but then immediately redirects somewhere else (often a live webpage instead of an archived copy). The page *looks* fine, but things aren't highlighted like you might expect. This change finds client-side redirects using the `<meta>` tag (and could handle other types of redirects in the future). It then removes them and adds a banner to the top of the page describing the redirect. This way, a user sees what was actually compared/diffed, and also gets notified about the redirect and has the option to investigate it. Partially covers #201.
When viewing a diff of a page that has client-side redirects, the experience can be pretty confusing. Because we are diffing the page's HTML, you never see the actual comparison. The comparison loads, but then immediately redirects somewhere else (often a live webpage instead of an archived copy). The page *looks* fine, but things aren't highlighted like you might expect. This change finds client-side redirects using the `<meta>` tag (and could handle other types of redirects in the future). It then removes them and adds a banner to the top of the page describing the redirect. This way, a user sees what was actually compared/diffed, and also gets notified about the redirect and has the option to investigate it. Partially covers #201.
When Scanner finds a page with the redirect, raise up a pop-up window (in frame) with the text below.
Close link goes the pop-up and stay on the original screen.
Proceed link goes to the redirect page.
"This page has a redirect to this url:
url.com
Close Proceed"
The text was updated successfully, but these errors were encountered: