Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed images cannot be deleted #282

Open
danroot opened this issue Jan 3, 2025 · 5 comments
Open

Failed images cannot be deleted #282

danroot opened this issue Jan 3, 2025 · 5 comments
Labels
good first issue Good for newcomers

Comments

@danroot
Copy link

danroot commented Jan 3, 2025

When an image load fails for any reason, a "spinner" is shown indefinitely and the UI toggle is never shown. This means the user cannot delete the problem image.

To Reproduce:

  • Upload an image and save
  • Delete the image from the backend. This results in a 404, but similar could happen if an invalid image is uploaded, the uploader endpoints do something wrong, etc.
  • Reload the page
  • Observe the image shows 'loading' indicator indefinitely and the editorjs menu is never shown, meaning the image cannot be deleted via the UI.

Expected behavior is that the image shows a failed indicator and the editorjs menu for the block is still shown, allowing the user to delete and try again.

I believe the root cause is just that only "loaded" is being handled, not "error". Adding event handling should help, or making it such that the editorjs menu is not contingent on the block to finish loading.

@pranavmappoli
Copy link

@danroot got any solution ?

@pranavmappoli
Copy link

The image is showing on top while hovering the failed image, please see the screenshot below

Image

see the option on top right corner

@pranavmappoli
Copy link

@neSpecc Can you help here

@neSpecc neSpecc added the good first issue Good for newcomers label Jan 30, 2025
@ANTOJESSI
Copy link

@pranavmappoli

.image-tool--uploading .image-tool__image {
  display: none !important;  
}

Try adding this to the css.

This helps hide the preloader or spinner .

@CristinaFores
Copy link

I'm experiencing the same issue. When I cancel the image upload, the same problem occurs.
Thanks! 🙌

Grabacion.de.pantalla.2025-02-04.a.las.10.37.37.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants