Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish HTTPS support in a future release #9

Open
DevSecNinja opened this issue Oct 24, 2020 · 1 comment
Open

Finish HTTPS support in a future release #9

DevSecNinja opened this issue Oct 24, 2020 · 1 comment

Comments

@DevSecNinja
Copy link

First of all: thanks for your great work! I ran into an issue when enabling HTTPS. When I set #define NRF905API_HTTPS from 0 to 1, I get the following error message:

<path>\nRF905-API\src\nRF905API\nRF905API.ino: In function 'void setup()':

nRF905API:194:54: error: 'serverCert' was not declared in this scope

  server.getServer().setRSACert(new BearSSL::X509List(serverCert), new BearSSL::PrivateKey(serverKey));

                                                      ^

nRF905API:194:91: error: 'serverKey' was not declared in this scope

  server.getServer().setRSACert(new BearSSL::X509List(serverCert), new BearSSL::PrivateKey(serverKey));
                                                                                         ^
exit status 1
'serverCert' was not declared in this scope

When I change NRF905API_HTTPS back to 1, it compiles successfully.

@eelcohn
Copy link
Owner

eelcohn commented Oct 24, 2020

That happens because I haven't finished HTTPS supoort yet :) I'll finish that in a future release (y)

@eelcohn eelcohn changed the title HTTPS: 'serverCert' was not declared in this scope Finish HTTPS support in a future release Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants