Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config file support for storage provider #670

Closed
aidan46 opened this issue Jan 7, 2025 · 2 comments
Closed

feat: Add config file support for storage provider #670

aidan46 opened this issue Jan 7, 2025 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@aidan46
Copy link
Contributor

aidan46 commented Jan 7, 2025

Supporting TOML and/or YAML files to pass config into the storage provider would make it easier to have a consistent configuration. Currently, the P2P config has been implemented to add support for TOML files. The other config values should have support for reading from config file too.

@jmg-duarte
Copy link
Contributor

There's more to this than just "adding a config file".

  • Do the CLI options override the respective config?
  • Maintaining both CLI options and config file is a bit of a PITA, should we remove the CLI options all together?
  • Should we support the "@" dialect?
  • Do we need to provide an "init" command to generate a default config?

@jmg-duarte
Copy link
Contributor

closed by #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants