Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage-provider-pallet): call verify_deals when precommiting #147

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix(storage-provider-pallet): call verify_deals when precommiting #147

merged 3 commits into from
Jul 22, 2024
+206 −74

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Jul 18, 2024 •
edited
Loading

Description

Fixes #117.

All of the deals that are part of the sector when being pre-committed should be validated.
This introduces the call to Market::verify_deals_for_activation and simplifies some tests.

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?

@th7nder th7nder mentioned this pull request Jul 18, 2024
Closed
@th7nder th7nder force-pushed the fix/117/verify-deals-pre-commit branch from 4ac1d86 to 31af488 Compare July 19, 2024 07:51
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 19, 2024
@th7nder th7nder self-assigned this Jul 19, 2024
@th7nder th7nder added this to the Phase 1 milestone Jul 19, 2024
@th7nder th7nder force-pushed the fix/117/verify-deals-pre-commit branch 3 times, most recently from cbc6000 to 1d574ab Compare July 19, 2024 09:09
@th7nder th7nder force-pushed the fix/117/verify-deals-pre-commit branch from 112e93a to 47333c9 Compare July 19, 2024 09:59
@th7nder th7nder requested review from cernicc and jmg-duarte July 19, 2024 10:01
@th7nder th7nder added bug Something isn't working ready for review Review is needed labels Jul 19, 2024
@th7nder th7nder marked this pull request as ready for review July 19, 2024 10:01
@th7nder th7nder force-pushed the fix/117/verify-deals-pre-commit branch from 47333c9 to 8827356 Compare July 19, 2024 10:37
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 19, 2024
@th7nder th7nder force-pushed the fix/117/verify-deals-pre-commit branch from 8827356 to 184a805 Compare July 19, 2024 12:03
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 19, 2024
@th7nder th7nder requested a review from jmg-duarte July 21, 2024 18:40
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jul 22, 2024
@jmg-duarte jmg-duarte merged commit 5f41a25 into develop Jul 22, 2024
3 checks passed
@jmg-duarte jmg-duarte deleted the fix/117/verify-deals-pre-commit branch July 22, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@cernicc cernicc cernicc approved these changes

Assignees

@th7nder th7nder

Labels
bug Something isn't working ready for review Review is needed
Projects
None yet
Milestone
Phase 1
Development

Successfully merging this pull request may close these issues.

SP Pallet: implement deal verification
3 participants
@th7nder @cernicc @jmg-duarte