-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Npx goal adds --registry as an argument of the executable command #1005
Comments
Faced a similar problem while working with |
Looks like yarn use npm registry property... https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/YarnMojo.java |
@rsynek Looks like there is WA:
magic in |
Bugfix is coming in this PR: #1013 |
#1013 merged; closing this issue. |
Need to upgrade Node version since Javascript introduced new syntax the old version could not recognized. Because eirslett/frontend-maven-plugin#1005 was resolved, I was able to remove the exec plugin and replace it with a npx execution in the frontend-maven-plugin. Changed the ui-bundle to the Antora 3 ui-bundle. Updated supplemental-ui to match new expected layout.
Need to upgrade Node version since Javascript introduced new syntax the old version could not recognized. Because eirslett/frontend-maven-plugin#1005 was resolved, I was able to remove the exec plugin and replace it with a npx execution in the frontend-maven-plugin. Changed the ui-bundle to the Antora 3 ui-bundle. Updated supplemental-ui to match new expected layout. Because Lunr extension is officially supported by Antora, its license is changed from MIT to MPL-2.0 (which matches the license the supplemental-ui and the ui-bundle zip are under).
Need to upgrade Node version since Javascript introduced new syntax the old version could not recognized. Because eirslett/frontend-maven-plugin#1005 was resolved, I was able to remove the exec plugin and replace it with a npx execution in the frontend-maven-plugin. Changed the ui-bundle to the Antora 3 ui-bundle. Updated supplemental-ui to match new expected layout. Because Lunr extension is officially supported by Antora, its license is changed from MIT to MPL-2.0 (which matches the license the supplemental-ui and the ui-bundle zip are under).
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
The plugin adds
--registry
as an argument of the commandnpx
is supposed to execute. The build fails as the command does not recognize the--registry
option.If the current behavior is a bug, please provide the steps to reproduce.
npx
, e.g.:mvn generate-resources -DnpmRegistryURL=https://some.repository.org
error: unknown option '--registry=https://some.repository.org'
asantora
does not recognize the--registry
option.What is the expected behavior?
The plugin should prepend the
npx
arguments before the command, see https://docs.npmjs.com/cli/v7/commands/npx#npx-vs-npm-exec. However, the--registry
option does not seem to be supported bynpx
anyway.Please mention your frontend-maven-plugin and operating system version.
1.12.0
Ubuntu 20.04.3 LTS
The text was updated successfully, but these errors were encountered: