Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid modification of https.protocols #1171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid modification of https.protocols #1171

wants to merge 1 commit into from

Conversation

kelunik
Copy link
Contributor

@kelunik kelunik commented Jan 13, 2025

This disables TLSv1.3 and changes global state that shouldn't be changed.

Fixes #1170.

@kelunik
Avoid modification of https.protocols
4d8c7e7 
This disables TLSv1.3 and changes global state that shouldn't be changed.

Fixes eirslett#1170.
@kelunik
Copy link
Contributor Author

kelunik commented Jan 13, 2025

The AppVeyor build doesn't seem active in this PR, so not sure whether it still works without the config option or not.

@kelunik kelunik mentioned this pull request Jan 13, 2025
Open
@pitgrap
Copy link
Contributor

pitgrap commented Jan 14, 2025

LGTM. Did you test it locally with your TLS1.3 setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileDownloader disables TLSv1.3
2 participants
@kelunik @pitgrap