Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ESApi class methods to use ES client calls instead of temporary wrapper methods #3110

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mattnowzari
Copy link

@mattnowzari mattnowzari commented Jan 15, 2025

Closes #2964

This PR updates the few methods of class ESApi to utilize ES client methods instead of TemporaryConnectorAPIWrapper methods. This does not fully replace all of the methods of TemporaryConnectorAPIWrapper, as we are waiting on ES client v8.17.1 to support sync_job_claim and sync_job_update_stats API calls. This will be attended to post-8.17.1 release.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

@mattnowzari mattnowzari changed the title Updated some ESApi class methods to use ES client calls instead of temporary wrapper methods Updating ESApi class methods to use ES client calls instead of temporary wrapper methods Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ES client for Connector API calls
2 participants