Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Can we include "kubectl get all" and "kubectl get all -o wide" in ECK diagnostics? #57

Open
kunisen opened this issue Oct 23, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@kunisen
Copy link

kunisen commented Oct 23, 2021

For troubleshooting purpose, having the output of the following 2 commands are more intuitive than current viewing pods.json/deployments.json/etc and do some formatting.

  • kubectl get all
  • kubectl get all -o wide

(It's very similar to have _cat/nodes and nodes.json at the same time which is what we have for Elasticsearch diagnostics)

Would also like to have -o wide is because it can show which object is on which k8s node, which could be helpful for particular troubleshooting case.

@kunisen kunisen added the enhancement New feature or request label Oct 23, 2021
@sebgl
Copy link

sebgl commented Oct 25, 2021

@kunisen to make sure I get the feature request right: the goal here is not to get information about more k8s resources (get all returns things we may not care about), but rather to provide a "summary" of the resources we care about in a format that is easier to digest than the full JSON arrays in multiple files?

@kunisen
Copy link
Author

kunisen commented Oct 25, 2021

Thanks! @sebgl
Indeed, it's rather to provide a "summary" + "list" for quick reference.
A good example is recently we hit an issue that readiness probe made some pods become 0/1 ready.
It's really hard to view from json file but if we can have kubectl get pods then we can view the 0/1 or 1/1 very quickly.

This similarly expands to all resources so I raised the request for get all.

Hope that's clear!

sakurai-youhei added a commit to sakurai-youhei/eck-diagnostics that referenced this issue Apr 6, 2023
@thbkrkr
Copy link
Contributor

thbkrkr commented Apr 26, 2023

We are quite reluctant to make this enhancement because:

  • Users have already complained about the size of the diagnosis and it adds files when the data is already present in the diagnosis even if it's small files.
  • Apply the filters to the get commands seems a bit hacky.

Wouldn't it be better to put our efforts into a diagnostic visualization tool?

@kunisen
Copy link
Author

kunisen commented Jul 7, 2023

@VimCommando Per comment above, maybe it's a good topic for how to make our internal visualization tool easier to use. :)

@VimCommando
Copy link

VimCommando commented Jul 7, 2023

I am all for getting visualizations going on our data. We just need ECK diags to be supported first:

https://github.com/elastic/<internal support ops related repository>/issues/476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants