From 28f17867ad564caf2c37881be7bfbd467714c058 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Mon, 11 Nov 2024 17:13:08 -0800 Subject: [PATCH] Remove `no-extra-semicolons` stylelint rule - at this point it's creating more false positives with nested template literals than it is being helpful --- packages/eui/.stylelintrc.js | 3 --- .../eui/src/components/date_picker/react_date_picker.styles.ts | 1 - packages/eui/src/components/form/range/range_slider.styles.ts | 1 - 3 files changed, 5 deletions(-) diff --git a/packages/eui/.stylelintrc.js b/packages/eui/.stylelintrc.js index 42adc41f28c7..3c973578d391 100644 --- a/packages/eui/.stylelintrc.js +++ b/packages/eui/.stylelintrc.js @@ -151,9 +151,6 @@ module.exports = { ignoreKeywords: [camelCaseValueRegex], }, ], - // This is set to deprecate after stylelint v16, but in the meanwhile, is helpful - // for finding extraneous semicolons after utils that already output semicolons (e.g. logicalCSS()) - 'no-extra-semicolons': true, // Emotion uses the `label` property to generate the output className string 'property-no-unknown': [true, { ignoreProperties: 'label' }], diff --git a/packages/eui/src/components/date_picker/react_date_picker.styles.ts b/packages/eui/src/components/date_picker/react_date_picker.styles.ts index 41f84749d539..33cf1fd1d342 100644 --- a/packages/eui/src/components/date_picker/react_date_picker.styles.ts +++ b/packages/eui/src/components/date_picker/react_date_picker.styles.ts @@ -249,7 +249,6 @@ export const _dayCalendarStyles = (euiThemeContext: UseEuiTheme) => { .react-datepicker__day-names, .react-datepicker__week { display: flex; - /* stylelint-disable no-extra-semicolons */ justify-content: space-between; flex-grow: 1; color: ${euiTheme.colors.subduedText}; diff --git a/packages/eui/src/components/form/range/range_slider.styles.ts b/packages/eui/src/components/form/range/range_slider.styles.ts index fd1977f986d0..a0ba871b8dd6 100644 --- a/packages/eui/src/components/form/range/range_slider.styles.ts +++ b/packages/eui/src/components/form/range/range_slider.styles.ts @@ -65,7 +65,6 @@ export const euiRangeSliderStyles = (euiThemeContext: UseEuiTheme) => { block-size: ${range.thumbHeight}; /* the track has the same height as the thumb */ `, hasRange: css` - /* stylelint-disable no-extra-semicolons */ ${euiRangeTrackPerBrowser(` background-color: transparent; border-color: ${transparentize(range.trackBorderColor, 0.6)}