Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] components page number is not formated according to i18n #8281

Open
johannes-darms opened this issue Jan 17, 2025 · 0 comments
Open
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible

Comments

@johannes-darms
Copy link

Describe the bug
The pagination component does not use i18n formatting for page numbers.

Impact and severity
This is not a really big issue for users, but also a small change to improve pagination with large number of pages.

Environment and versions

  • EUI version: v99.9

To Reproduce
cf. screenshot and snippet below (also active on the documentation page: https://eui.elastic.co/#/navigation/pagination )

Expected behavior
Use i18n formatted values for pages. https://github.com/elastic/eui/blob/main/packages/eui/src/components/pagination/pagination_button.tsx#L35

Minimum reproducible sandbox

<EuiPagination
  pageCount={27000000000000}
  activePage={480000000000}
  />

Screenshots

Image

@johannes-darms johannes-darms added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Jan 17, 2025
@johannes-darms johannes-darms changed the title Pagination components page number is not formated according to i18n [Pagination] components page number is not formated according to i18n Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible
Projects
None yet
Development

No branches or pull requests

1 participant