Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard][canvas] Replace VisTypes and VisTypeAliases in Add Panel Menu #209022

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

[dashboard][canvas] Replace VisTypes and VisTypeAliases in Add Panel Menu #209022

wants to merge 24 commits into from
+418 −488

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 30, 2025 •
edited
Loading

Closes #180057

The following items needed to be replaced with add panel actions

  • vega - visType
  • markdown - visType
  • lens - visTypeAlias
  • maps - visTypeAlias

As an added benefit, now these actions are displayed in embeddable examples that uses ADD_PANEL_TRIGGER

@nreese nreese changed the title [dashboard] only show items from ADD_PANEL_TRIGGER in add panel flyout [dashboard] Replace VisTypes and VisTypeAliases in Add Panel Menu Jan 30, 2025
@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese nreese force-pushed the only_add_panel_action branch from a16dcdf to ec5700f Compare January 31, 2025 16:38
@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / dashboard app - group 1 edit visualizations from dashboard save button returns to dashboard after editing visualization with changes saved
  • [job] [logs] FTR Configs #40 / dashboard app - group 1 edit visualizations from dashboard save button returns to dashboard after editing visualization with changes saved
  • [job] [logs] FTR Configs #64 / lens app - group 4 lens dashboard tests should work in lens with by-value charts
  • [job] [logs] FTR Configs #64 / lens app - group 4 lens dashboard tests should work in lens with by-value charts
  • [job] [logs] FTR Configs #61 / maps app embeddable maps in embeddable library "before all" hook for "save map panel to embeddable library"
  • [job] [logs] FTR Configs #61 / maps app embeddable maps in embeddable library "before all" hook for "save map panel to embeddable library"

History

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Feb 2, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Feb 3, 2025

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Feb 3, 2025

/ci

@nreese nreese marked this pull request as ready for review February 3, 2025 16:24
@nreese nreese requested review from a team as code owners February 3, 2025 16:24
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Feb 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added Feature:Dashboard Dashboard related features Feature:Canvas labels Feb 3, 2025
@nreese nreese changed the title [dashboard] Replace VisTypes and VisTypeAliases in Add Panel Menu [dashboard][canvas] Replace VisTypes and VisTypeAliases in Add Panel Menu Feb 3, 2025
@nreese nreese added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Feb 3, 2025
jloleysens
jloleysens approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, kibana.jsonc changes LGTM

@nreese
Copy link
Contributor Author

nreese commented Feb 5, 2025

@elasticmachine merge upstream

@nreese nreese force-pushed the only_add_panel_action branch from 9df9b1c to 02c0a09 Compare February 5, 2025 19:18
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1226 1225 -1
lens 1815 1817 +2
maps 1337 1338 +1
visTypeMarkdown 23 62 +39
visTypeVega 289 328 +39
total +80

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB -1.3KB
dashboard 601.8KB 601.1KB -762.0B
lens 1.6MB 1.6MB -5.2KB
maps 3.0MB 3.0MB +1.0KB
visTypeMarkdown 7.0KB 8.6KB +1.6KB
visTypeVega 1.9MB 1.9MB +1.6KB
total -3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 14.4KB 14.2KB -199.0B
dashboard 17.8KB 17.7KB -144.0B
lens 50.2KB 49.4KB -823.0B
maps 51.9KB 52.3KB +412.0B
visTypeMarkdown 7.2KB 7.9KB +716.0B
visTypeVega 33.8KB 34.7KB +896.0B
total +858.0B
Unknown metric groups

async chunk count

id before after diff
maps 34 35 +1
visTypeMarkdown 2 3 +1
visTypeVega 8 9 +1
total +3

References to deprecated APIs

id before after diff
lens 88 87 -1

History

@nreese
Copy link
Contributor Author

nreese commented Feb 6, 2025

@elasticmachine merge upstream

@nreese nreese removed the request for review from a team February 6, 2025 20:16
@nickpeihl nickpeihl self-requested a review February 6, 2025 20:26
nickpeihl
nickpeihl approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dashboard and canvas changes lgtm! nice cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@jloleysens jloleysens jloleysens approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Canvas Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Embeddables] Replace Vis Aliases in Add Panel Menu
5 participants
@nreese @elasticmachine @nickpeihl @jloleysens @kibanamachine