Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React@18 QA] @elastic/kibana-data-discovery #210134

Closed
2 tasks done
kertal opened this issue Feb 7, 2025 · 4 comments
Closed
2 tasks done

[React@18 QA] @elastic/kibana-data-discovery #210134

kertal opened this issue Feb 7, 2025 · 4 comments
Assignees
Labels
chore Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Feb 7, 2025

Part of #203114.

Summary

Manual QA of our UI using React

  • Discover
  • Data View Management

How to test

Testing can be done locally by using the PR (#209337) or from main with REACT_18=true ENV flag:

REACT_18=true yarn kbn bootstrap
REACT_18=true yarn start

You can also use cloud or serverless deployment from that PR.

Tip

  • Locally you can tell that you're running React@18 by the following message in the console: Kibana is built with and running [email protected], muting legacy root warning.
  • When deployed and when having React Dev Tools extension you can check the version with __REACT_DEVTOOLS_GLOBAL_HOOK__.renderers.get(1).version in console

What to look for

Tip

Look for blank screens, error splash screens, unresponsive pages, new errors in the console, unpredictable UI behavior (like laggy text inputs that skip letters when typing fast). You can also review the list of addressed runtime issues discovered by functional tests in the section below

@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 7, 2025
@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Feb 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 7, 2025
@kertal kertal added chore needs-team Issues missing a team label labels Feb 7, 2025
@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 7, 2025
@akowalska622
Copy link
Contributor

akowalska622 commented Feb 11, 2025

Tested:

  • Discover table (sorting, pagination, expanding one document, search in table, row customization, fullscreen mode, field statistics, field drag and drop, filtering entries from table rows, no results screen)
  • Comparing documents
  • View single document
  • View surrounding documents
  • Exporting via text and JSON
  • All inputs I could think of
  • Intervals and breakdowns in histogram
  • Adding a new field
  • Single field popup from fields list
  • Filtering table from fields list
  • Toggling fields list and histogram visibility
  • Managing data view (adding a new one, editing existing one)
  • Inspect flyout
  • Alerts popup
  • Managing Discover sessions

Everything looks good ✅
No blank screens, no laggy inputs, no (new*) console errors, no unresponsive pages.

*I've compared all console errors I've encountered to main branch, most were about lack of key in mapped children, but all the same, in the same places in both branches. I've created a list though, so we can handle them as a technical debt when possible 😁

@kertal should we close or you have some more ideas where to peak? Or you want to do a final round with fresh pair of eyes?

@kertal
Copy link
Member Author

kertal commented Feb 11, 2025

Great job @akowalska622 , let's just ping our team, in case somebody has another idea what to test, and close it tomorrow, in case there's no more additional input. Let's open issues then if we find something. Thx a log!

FYI @elastic/kibana-data-discovery

@akowalska622
Copy link
Contributor

Sounds great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants