Skip to content
This repository has been archived by the owner on Apr 22, 2018. It is now read-only.

Keyboard Support + ARIA #18

Open
grayghostvisuals opened this issue Oct 26, 2016 · 3 comments
Open

Keyboard Support + ARIA #18

grayghostvisuals opened this issue Oct 26, 2016 · 3 comments

Comments

@grayghostvisuals
Copy link

I don't see any ability to close modals using the esc key. I think this is a cool project that could definitely take from bootstrap's ARIA use and implement with this project…maybe even better. Thoughts?

@davidbwaters
Copy link

I've been exploring light, vanilla modal solutions. One I was considering (before I found this), here, checks for mousetrap.js as an optional dependency and uses it for keyboard control. This would be a way to add keyboard controls without adding bloat.

@electerious
Copy link
Owner

ARIA support would be nice. Keyboard support is possible, but not directly part of basicModal. You can simply check if the user presses the ESC key and fire basicModal.close. It's not build-in because you might want to execute a different ESC action depending on the state of your app/site.

@JacobDB
Copy link

JacobDB commented Feb 8, 2017

Besides the esc key, in your demos I can't seem to tab to the x button or get out of the modal at all unless I click on the x button. I love how these work & look, but I can't use them if they're not accessible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants