Internal: Add custom escaper for template renderer [ED-18015] #30189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleShit
requested changes
Feb 9, 2025
| @@ -0,0 +1,12 @@ | |||
| {# TODO: Need to add base classes #} | |||
| <{{ settings.tag | e('html_tag') }} | |||
There was a problem hiding this comment.
shouldn't it come sanitized from the props resolver?
There was a problem hiding this comment.
We have some validations, but as for today we validate it and also when printing sanitize it, just like full_url, this is the same. not sure about it, what do you think? I think if we are going to remove it, we also need to remove full_url
StyleShit
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.