Fix: Load font family on atomic styles render [ED-18041] #30241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleShit
requested changes
Feb 13, 2025
tests/phpunit/elementor/modules/atomic-widgets/styles/test-styles-renderer.php
Outdated
Show resolved
Hide resolved
blackcolt
reviewed
Feb 16, 2025
| @@ -35,7 +35,14 @@ private function inject_global_classes( Post_CSS $post ) { | |||
|
|
|||
| $css = Styles_Renderer::make( | |||
| Plugin::$instance->breakpoints->get_breakpoints_config() | |||
| )->render( $sorted_items->all() ); | |||
| )->on_prop_transform( function($key, $value ) use ( &$post ) { | |||
There was a problem hiding this comment.
@StyleShit - why not extract this to a function?
StyleShit
requested changes
Feb 16, 2025
| $this->elements_manager_mock->method( 'get_element_types' )->willReturn( [] ); | ||
|
|
||
| Plugin::$instance->kits_manager->create_new_kit( 'kit' ); | ||
| $kit = Plugin::$instance->kits_manager->get_active_kit(); |
There was a problem hiding this comment.
Suggested change
| $kit = Plugin::$instance->kits_manager->get_active_kit(); | |
| $kit = Plugin::$instance->kits_manager->get_active_id(); |
| @@ -483,6 +483,7 @@ public function test_render__style_with_nested_background_image_transformers() { | |||
| $this->assertNotEmpty( $css, 'CSS should not be empty' ); | |||
| $this->assertMatchesSnapshot( $css ); | |||
| } | |||
|
|
|||
| ); | ||
|
|
||
| // Act. | ||
| $post_css = $this->regenerate_kit_css(); |
StyleShit
previously approved these changes
Feb 16, 2025
IshayMaya
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.