Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning with elixir 1.18 #579

Open
epinault opened this issue Dec 27, 2024 · 5 comments
Open

Warning with elixir 1.18 #579

epinault opened this issue Dec 27, 2024 · 5 comments

Comments

@epinault
Copy link

I am on OTP 27.2, elixir 1.18.0 and I see this

warning: using map.field notation (without parentheses) to invoke function Faker.Random.Elixir.random_uniform() is deprecated, you must add parentheses instead: remote.function()
  (faker 0.18.0) lib/faker.ex:109: Faker.random_uniform/0
  (faker 0.18.0) lib/faker/address.ex:188: Faker.Address.latitude/0
  test/my_app/admin/location_test.exs:13: anonymous fn/2 in :elixir_compiler_3.__MODULE__/1
  (ex_unit 1.18.0) lib/ex_unit/callbacks.ex:787: ExUnit.Callbacks.__describe__/4
  test/my_app/admin/location_test.exs:8: (module)
  (elixir 1.18.0) src/elixir_compiler.erl:77: :elixir_compiler.dispatch/4
  (elixir 1.18.0) src/elixir_compiler.erl:52: :elixir_compiler.compile/4
  (elixir 1.18.0) src/elixir_module.erl:454: :elixir_module.eval_form/7
  (elixir 1.18.0) src/elixir_module.erl:156: :elixir_module.compile/7
  (elixir 1.18.0) src/elixir_compiler.erl:38: :elixir_compiler.maybe_fast_compile/2
  (elixir 1.18.0) src/elixir_lexical.erl:13: :elixir_lexical.run/3
  (elixir 1.18.0) src/elixir_compiler.erl:17: :elixir_compiler.quoted/3
  (elixir 1.18.0) lib/kernel/parallel_compiler.ex:562: Kernel.ParallelCompiler.require_file/2
  (elixir 1.18.0) lib/kernel/parallel_compiler.ex:445: anonymous fn/5 in Kernel.ParallelCompiler.spawn_workers/
@matt-savvy
Copy link

Looks like that's the same as #569. Been getting this warning since Elixir 1.17

@epinault
Copy link
Author

@matt-savvy yea I guess . then wonder when it will get fixed :/

@epinault
Copy link
Author

@anthonator @tobyhinloopen @vbrazo Do you need help here? I see quite a few PR piling. Do you need more maintainers?

@tobyhinloopen
Copy link
Contributor

tobyhinloopen commented Jan 30, 2025

I have been summoned!

It has been a while since I looked at this repo. I think it's wise that the maintainers (that might be me? Im not sure if I even am a maintainer at the moment, but according to the readme I am) schedule a moment where we discuss how we can get through the open PRs, and what to do with future PRs.

I'm happy to review PRs. I think it's wise to prioritize PRs that fix compatibility issues with recent elixir versions.

Edit:

Image

I am not, hah

@igas
Copy link
Member

igas commented Jan 31, 2025

Thanks @tobyhinloopen, it's been awhile. I think we discussed that you don't work with elixir day to day and don't have time. I've joined Alembic recently, I'll discuss it with the team there, I'm sure I'll be able to bring more maintainers. I started to cleanup PRs. Should cut release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants