Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for the release of php-ts-mode #38

Open
1 task done
zonuexe opened this issue Aug 28, 2023 · 3 comments
Open
1 task done

Preparing for the release of php-ts-mode #38

zonuexe opened this issue Aug 28, 2023 · 3 comments

Comments

@zonuexe
Copy link
Member

zonuexe commented Aug 28, 2023

Organize TODOs for submitting php-ts-mode package to GNU ELPA.

@eliphazbouye
Copy link

What important things to do for php-ts-mode work?

@akirak
Copy link
Contributor

akirak commented Jun 21, 2024

GNU Emacs is about to ship a library with the same name (i.e. php-ts-mode) which is written by a different person named Vincenzo Pupillo:

https://mail.gnu.org/archive/html/bug-gnu-emacs/2024-06/msg00294.html

It's already in the master branch. It seems to contain more code (1654 lines) than the source file in this repository, but I don't know if it is better in features/quality. What will you do?

@piotrkwiecinski
Copy link
Contributor

I mentioned it in #71 (comment).

It's already ie emacs master and it's more feature complete than what we have.

It already includes support for:

  • multiple php coding styles
  • highlights for phpdoc,css,js in php files
  • php lint integration for flymake
  • built-in php server support

I reckon it would be the best to deprecate this repo and point people to the core and send patches to Emacs directly.

We could start with porting indentation tests from this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants