Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: ignoring input sourcemap for ember-testing.js while build after update to ember-source v6.1 #2228

Open
mkszepp opened this issue Jan 13, 2025 · 3 comments

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Jan 13, 2025

After upgrade to ember-source v6.1 i'm getting in the project following warning:

Warning: ignoring input sourcemap for ../rewritten-packages/@embroider/synthesized-vendor/vendor/ember/ember-testing.js because ENOENT: no such file or directory, open '/home/user/projects/test/new-app/node_modules/.embroider/rewritten-packages/@embroider/synthesized-vendor/vendor/ember/ember-template-compiler.js.map'

Reproduce

  1. ember new new-app --embroider --pnpm --typescript
  2. ember s
@chancancode
Copy link
Contributor

Part 1 of the issue is ember-source didn't include the source map2: emberjs/ember.js#20850

Part 2 of the issue is https://github.com/embroider-build/embroider/pull/2164/files#diff-f8d6d1f14d39a8b63e24a8f0dd11dbc5b9c931b006354e3139de3c8844ea337c needs to copy over the source maps, probably conditionally, as there are old versions of ember-source that doesn't have them out there. Or it could scrub the file content clean of the invalid source map reference before writing it back out.

As an aside, I think that code is bugged. It seems like @ef4 had a typo in there that wrote the content of the template compiler into the wrong file name. Apps that are consuming the template-compiler that way (with app.import() it seems?) are probably broken right now.

@mkszepp
Copy link
Contributor Author

mkszepp commented Feb 23, 2025

@ef4 @chancancode is this issue fixed by #2305 or?

@chancancode
Copy link
Contributor

I think Ed expects it would, as long as you are not doing app.import on the template compiler 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants