Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using Vite with older ember-source versions - ideally 3.28+ #2287

Open
Tracked by #1860
mansona opened this issue Feb 19, 2025 · 0 comments
Open
Tracked by #1860

Comments

@mansona
Copy link
Member

mansona commented Feb 19, 2025

Currently the CI for embroider on the main branch is only testing ember-source v5.8+ because that is the first LTS that fixed a number of module cycles that the Vite build system exposed. We intend to support all the way back to 3.28 but to do so we will need some way to automatically apply a patch to ember-source that fixes the main module cycle that people will likely hit.

you can see an example of that patch here: https://github.com/ember-learn/ember-api-docs/blob/9e1e456167e826405299df2483f909ab1aeacf0b/patches/ember-source%403.28.12.patch

We probably want to apply a patch like this automatically against ember-source in a compat adapter (i.e. during the v2 upgrade process).

Once this is done we can unskip the versions in both the supportMatrix() and fullSupportMatrix() in scenario tester on the Embroider CI https://github.com/embroider-build/embroider/blob/main/tests/scenarios/scenarios.ts#L78-L118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant