You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the CI for embroider on the main branch is only testing ember-source v5.8+ because that is the first LTS that fixed a number of module cycles that the Vite build system exposed. We intend to support all the way back to 3.28 but to do so we will need some way to automatically apply a patch to ember-source that fixes the main module cycle that people will likely hit.
Currently the CI for embroider on the main branch is only testing ember-source v5.8+ because that is the first LTS that fixed a number of module cycles that the Vite build system exposed. We intend to support all the way back to 3.28 but to do so we will need some way to automatically apply a patch to ember-source that fixes the main module cycle that people will likely hit.
you can see an example of that patch here: https://github.com/ember-learn/ember-api-docs/blob/9e1e456167e826405299df2483f909ab1aeacf0b/patches/ember-source%403.28.12.patch
We probably want to apply a patch like this automatically against ember-source in a compat adapter (i.e. during the v2 upgrade process).
Once this is done we can unskip the versions in both the
supportMatrix()
andfullSupportMatrix()
in scenario tester on the Embroider CI https://github.com/embroider-build/embroider/blob/main/tests/scenarios/scenarios.ts#L78-L118The text was updated successfully, but these errors were encountered: