-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measurement addition order #487
Comments
hey @brandon-holt In General Exotic Cases and Statefulness Here the two variants could differ if you disallowed the recommendation of previously recommended points via allow_recommending_already_recommended. The first variant has X already recommended i the first round, any points in X will not be considered again for the final recommendation. While the second variant, you also added X, but it was not recommended before, hence the final recommendation might recommend a point in X again. Computational Aspects |
Hey @Scienfitz! I see! But when searching on a more general framing of this topic: Lets assume I have a dataset of 40 separate measurements in the searchspace. Should i add them all at once, or add them one by one, updating the acquisition function and requesting recommendations after each point is added? My reading suggests Adding one by one allows the acquisition function to adapt dynamically after each new observation, potentially leading to a more efficient exploration-exploitation tradeoff. • If the 40 measurements are diverse and well-distributed across the search space, adding them all at once is reasonable. Is this accurate? Edit: after further reading i think im misinterpreting some things, the acquisition function should be the same at the end regardless of the order the points are added (or all at once). Just want to confirm this is true! |
yes I think in the situation you described in the first post, the acqf should be identical, hence identical outcome (unless some stateful aspects are present). When you already have 40 measurements, it does not make a difference if you add them all at once or in one big chunk. But be careful, this is similar to the related question of batching |
Right in My case its the same pre selected 40 points so the endpoint should be the same whatever order i add them in. Thanks! |
Exactly, no difference if the measurements have already been collected. But as @Scienfitz correctly pointed out, it absolutely makes a difference if you inform the campaign about new measurements WHILE you are still in the process of collecting the data. Here an excerpt from the campaign user guide, in case you haven't seen it yet: ![]() |
Is there a difference in the quality of recommendations that would come from
A) a naive model that is trained on dataset A, which then recommends datapoint X, which is tested, added to the model, and then making final recommendations
Vs
B) a naive model that is trained directly on dataset A + measured datapoint X, and then making final recommendations
Or should these be mathematically equivalent
Assume surrogate model is a gaussian process and acquisition function is expected improvement
The text was updated successfully, but these errors were encountered: