Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Don't re-download packages on every build #165

Closed
rvagg opened this issue Oct 15, 2012 · 2 comments
Closed

Don't re-download packages on every build #165

rvagg opened this issue Oct 15, 2012 · 2 comments

Comments

@rvagg
Copy link
Member

rvagg commented Oct 15, 2012

From #160:

Don't re-download packages for every build: a little like npm, it should be aware of what you have in node_modules/ and not download the same package every time you rebuild.

This is already working in 1.0-wip and I'm using it in my build-process already and it's brilliant because Ender runs so much quicker. However, my feeling is that it's not quite right with package versions and tags, I wouldn't mind having feedback from others who have tried this out.

This ticket is a reminder to further investigate the implementation and see if it can be improved before a 1.0 release.

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2013

this is in 1.0, there is a --force-install to override it.

@rvagg
Copy link
Member Author

rvagg commented Mar 19, 2013

BTW, I'm leaving this open for discussion as I'm not 100% convinced this is the right approach or that the current implementation gets it right.

Part of the problem is that we're not caring enough about versions, which we should. npm has a cache already but each time you call install it has to check for the latest version so it can mean a build takes forever. The primary objective here is to make builds fast where they can be so it's an easy decision to include ender in your build chain.

@rvagg rvagg closed this as completed Apr 11, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant