misc tightening of linting (#2615)

incidental ## Description Adopting `verbatimModuleSyntax` in agoric-sdk required a lot of changes so it thought it worthwhile to adopt here before more might be necessary. I made several other lint tooling bumps and config tightening as well. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI ### Compatibility Considerations none ### Upgrade Considerations none, dev deps
endojs · Oct 25, 2024 · d6c6c69 · d6c6c69
2 parents 4ca4028 + 7b5d004
commit d6c6c69
Show file tree

Hide file tree

Showing 49 changed files with 319 additions and 578 deletions.
diff --git a/package.json b/package.json
@@ -7,7 +7,7 @@
   "engines": {
     "node": ">=16"
   },
-  "packageManager": "yarn@4.4.0",
+  "packageManager": "yarn@4.5.1",
   "devDependencies": {
     "@jessie.js/eslint-plugin": "^0.4.1",
     "@octokit/core": "^3.4.0",
@@ -18,13 +18,13 @@
     "eslint-config-jessie": "^0.0.6",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jsdoc": "^48.2.5",
+    "eslint-plugin-jsdoc": "^50.4.3",
     "lerna": "^8.1.8",
-    "prettier": "^3.2.5",
+    "prettier": "^3.3.3",
     "type-coverage": "^2.29.1",
     "typedoc": "^0.26.6",
     "typedoc-plugin-markdown": "^4.2.5",
-    "typescript": "~5.6.2",
+    "typescript": "~5.6.3",
     "typescript-eslint": "^7.3.1",
     "zx": "^8.1.8"
   },

diff --git a/packages/base64/package.json b/packages/base64/package.json
@@ -50,8 +50,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/bundle-source/package.json b/packages/bundle-source/package.json
@@ -44,7 +44,7 @@
     "ava": "^6.1.3",
     "c8": "^7.14.0",
     "eslint": "^8.57.0",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "keywords": [],
   "files": [

diff --git a/packages/captp/package.json b/packages/captp/package.json
@@ -55,7 +55,7 @@
     "@endo/ses-ava": "workspace:^",
     "ava": "^6.1.3",
     "c8": "^7.14.0",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "dependencies": {
     "@endo/errors": "workspace:^",

diff --git a/packages/check-bundle/package.json b/packages/check-bundle/package.json
@@ -56,8 +56,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/cjs-module-analyzer/package.json b/packages/cjs-module-analyzer/package.json
@@ -40,8 +40,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -58,8 +58,8 @@
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
     "execa": "^9.3.0",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/cli/test/_types.d.ts b/packages/cli/test/_types.d.ts
@@ -2,7 +2,7 @@ import type { Execa } from 'execa';
 
 export type Expectation = {
   stdout: RegExp | string | undefined;
-  stderr: RegExp | string | undefined;
+  stderr?: RegExp | string | undefined;
 };
 export type TestCommand = (
   command: ReturnType<Execa>,

diff --git a/packages/cli/test/demo/confined-script.js b/packages/cli/test/demo/confined-script.js
@@ -1,4 +1,4 @@
-/** @import {TestRoutine} from '../types */
+/** @import {TestRoutine} from '../_types.js'; */
 
 /** @type {TestRoutine} */
 export const section = async (execa, testLine) => {

diff --git a/packages/common/package.json b/packages/common/package.json
@@ -51,7 +51,7 @@
     "ava": "^6.1.3",
     "c8": "^7.14.0",
     "tsd": "^0.31.2",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/compartment-mapper/package.json b/packages/compartment-mapper/package.json
@@ -70,8 +70,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/daemon/package.json b/packages/daemon/package.json
@@ -75,8 +75,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/daemon/src/worker-node-powers.js b/packages/daemon/src/worker-node-powers.js
@@ -2,7 +2,7 @@
 
 import { makeNodeReader, makeNodeWriter } from '@endo/stream-node';
 
-/** @import { MignonicPowers } from './types.js' } */
+/** @import {MignonicPowers} from './types.js'; */
 
 /**
  * @param {object} modules

diff --git a/packages/env-options/package.json b/packages/env-options/package.json
@@ -41,8 +41,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/errors/package.json b/packages/errors/package.json
@@ -45,7 +45,7 @@
     "c8": "^7.14.0",
     "ses0_18_3": "npm:[email protected]",
     "tsd": "^0.31.2",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/eslint-plugin/lib/configs/style.js b/packages/eslint-plugin/lib/configs/style.js
@@ -1,5 +1,9 @@
 module.exports = {
-  extends: ['airbnb-base', 'plugin:jsdoc/recommended', 'prettier'],
+  extends: [
+    'airbnb-base',
+    'plugin:jsdoc/recommended-typescript-flavor',
+    'prettier',
+  ],
   rules: {
     quotes: [
       'error',
@@ -22,13 +26,6 @@ module.exports = {
     'prefer-regex-literals': 'off',
     'no-else-return': 'off',
     'no-console': 'off',
-    'no-unused-vars': [
-      'error',
-      {
-        argsIgnorePattern: '^_',
-        varsIgnorePattern: '^_',
-      },
-    ],
     'no-return-assign': 'off',
     'no-param-reassign': 'off',
     'no-promise-executor-return': 'off', // common to return setTimeout(), we know the value won't be accessible

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -20,7 +20,7 @@
   "dependencies": {
     "requireindex": "~1.1.0",
     "tsutils": "~3.21.0",
-    "typescript": "~5.6.2",
+    "typescript": "~5.6.3",
     "typescript-eslint": "^7.3.1"
   },
   "devDependencies": {

diff --git a/packages/evasive-transform/package.json b/packages/evasive-transform/package.json
@@ -50,7 +50,7 @@
     "eslint": "^8.57.0",
     "rollup": "^2.79.1",
     "tsd": "^0.31.2",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/eventual-send/package.json b/packages/eventual-send/package.json
@@ -43,7 +43,7 @@
     "ava": "^6.1.3",
     "c8": "^7.14.0",
     "tsd": "^0.31.2",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "keywords": [
     "eventual send",

diff --git a/packages/exo/package.json b/packages/exo/package.json
@@ -51,8 +51,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/far/package.json b/packages/far/package.json
@@ -42,7 +42,7 @@
     "@endo/ses-ava": "workspace:^",
     "ava": "^6.1.3",
     "c8": "^7.14.0",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "keywords": [
     "eventual send",

diff --git a/packages/immutable-arraybuffer/package.json b/packages/immutable-arraybuffer/package.json
@@ -40,7 +40,7 @@
     "ava": "^6.1.3",
     "c8": "^7.14.0",
     "tsd": "^0.31.2",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/import-bundle/package.json b/packages/import-bundle/package.json
@@ -51,7 +51,7 @@
     "@endo/ses-ava": "workspace:^",
     "ava": "^6.1.3",
     "c8": "^7.14.0",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/init/package.json b/packages/init/package.json
@@ -31,7 +31,7 @@
   "devDependencies": {
     "@endo/compartment-mapper": "workspace:^",
     "ava": "^6.1.3",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "dependencies": {
     "@endo/base64": "workspace:^",

diff --git a/packages/lp32/package.json b/packages/lp32/package.json
@@ -65,8 +65,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/marshal/package.json b/packages/marshal/package.json
@@ -55,7 +55,7 @@
     "@fast-check/ava": "^1.1.5",
     "ava": "^6.1.3",
     "c8": "^7.14.0",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/memoize/package.json b/packages/memoize/package.json
@@ -46,8 +46,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/module-source/package.json b/packages/module-source/package.json
@@ -54,8 +54,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/nat/package.json b/packages/nat/package.json
@@ -36,9 +36,9 @@
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
+    "prettier": "^3.3.3",
     "ses": "workspace:^",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "directories": {
     "test": "test"

diff --git a/packages/netstring/package.json b/packages/netstring/package.json
@@ -49,8 +49,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/pass-style/package.json b/packages/pass-style/package.json
@@ -50,8 +50,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/pass-style/src/types.test-d.ts b/packages/pass-style/src/types.test-d.ts
@@ -3,7 +3,7 @@ import { expectAssignable, expectType, expectNotType } from 'tsd';
 import { Far } from './make-far.js';
 import { passStyleOf } from './passStyleOf.js';
 import { makeTagged } from './makeTagged.js';
-import { CopyTagged, Passable, PassStyle } from './types.js';
+import type { CopyTagged, Passable, PassStyle } from './types.js';
 import { PASS_STYLE } from './passStyle-helpers.js';
 
 const remotable = Far('foo', {});

diff --git a/packages/patterns/package.json b/packages/patterns/package.json
@@ -50,8 +50,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/promise-kit/package.json b/packages/promise-kit/package.json
@@ -49,8 +49,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/ses-ava/package.json b/packages/ses-ava/package.json
@@ -53,8 +53,8 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
-    "typescript": "~5.6.2"
+    "prettier": "^3.3.3",
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",

diff --git a/packages/ses/package.json b/packages/ses/package.json
@@ -93,10 +93,10 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "prettier": "^3.2.5",
+    "prettier": "^3.3.3",
     "terser": "^5.16.6",
     "tsd": "^0.31.2",
-    "typescript": "~5.6.2"
+    "typescript": "~5.6.3"
   },
   "files": [
     "./*.d.ts",