Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPassableError, assertPassableError, and toPassableError judge non-frozen errors to be passable. #2173

Closed
erights opened this issue Mar 24, 2024 · 0 comments · Fixed by #2156
Assignees
Labels
bug Something isn't working

Comments

@erights
Copy link
Contributor

erights commented Mar 24, 2024

Describe the bug

isPassableError, assertPassableError, and toPassableError judge non-frozen errors to be passable.

Steps to reproduce

PR #2156 , which would fix this bug, has the following test case

  const e = makeError('test error');
  // I include this test because I was recently surprised that the errors
  // make by `makeError` are not frozen, and therefore not passable.
  t.false(Object.isFrozen(e));
  t.false(isPassable(e));

  const e2 = toPassableError(e);

  t.is(e, e2);
  t.true (Object.isFrozen(e)); // currently fails
  t.true(isPassable(e)); // currently fails

Expected behavior

The test case shown above to pass

Platform environment

$ git describe --tags --always
@endo/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant