-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox fails to fire progress event without preload attribute #150
Comments
In v4 you can make changes to VideoLoadStrategy to support this. However, not every video should set this property because not every video should load the entire video.
Not strictly true, we actually wait until |
The problem I am seeing is that with Firefox 74, unless autoplay is set to true or preload is set to auto.
To me, |
For some video files (seems to primarily happen on MPEG 4 Type 2 files), the Progress event does not fire for a loaded resource on Firefox 74. This seems to be caused when not enough of the partial content range has been loaded by the browser's default
preload
value on a media element.Since the loader should be requesting that the resource be loaded fully, the
preload
attribute should be set toauto
.For the 3.x branch, I tested this by adding
this.data.preload = 'auto';
right beforethis.data.load();
here: https://github.com/englercj/resource-loader/blob/release/3.x/src/Resource.js#L636. However, this should probably be wrapped in an if statement to only add preload to a video type element.You can see that a video is not being preloaded with any video file by watching the network traffic and seeing that only the first bits of the file are downloaded. This doesn't seem to cause the progress event failure for all videos, though. I can link to a video that causes the progress issue reliably in a private message, or I can try to find or create a free video that causes the issue if needed.
The text was updated successfully, but these errors were encountered: