Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure classification is right after split #141

Open
enoch3712 opened this issue Dec 21, 2024 · 1 comment
Open

Make sure classification is right after split #141

enoch3712 opened this issue Dec 21, 2024 · 1 comment
Assignees
@enoch3712
Labels
0.1.0 bug Something isn't working
Milestone
0.1.0

Comments

@enoch3712
Copy link
Owner

image

Sometimes, as you can see in the image above, the code can have some problems picking the correct classification. This happens because returns the name, what is not the best ID to use

Lets add a number to the classification so it makes less mistakes
@enoch3712 enoch3712 added the bug Something isn't working label Dec 21, 2024
@enoch3712 enoch3712 added this to the 0.1.0 milestone Dec 21, 2024
@enoch3712 enoch3712 self-assigned this Dec 21, 2024
@enoch3712
Copy link
Owner Author

Please use test_process.test_eager_splitting_strategy_text to test this flacky problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enoch3712 enoch3712

Labels
0.1.0 bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

141-make-sure-classification-is-right-after-split enoch3712/ExtractThinker
1 participant
@enoch3712