Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression update should contain full multi-value info #12153

Closed
4e6 opened this issue Jan 27, 2025 · 14 comments · Fixed by #12195
Closed

Expression update should contain full multi-value info #12153

4e6 opened this issue Jan 27, 2025 · 14 comments · Fixed by #12195

Comments

@4e6
Copy link
Contributor

4e6 commented Jan 27, 2025

The EnsoMutliValue was updated to carry dispatch and extra sets of types.

public final class EnsoMultiValue extends EnsoObject {
private final EnsoMultiType dispatch;
private final EnsoMultiType extra;
private final int firstDispatch;

The ExpressionUpdate message returns only a union of dispatch and extra set of types of a multi-value (aka intersection type)

interface ExpressionUpdate {
  /** The id of updated expression. */
  expressionId: ExpressionId;
  /** The updated type of the expression.
   *
   *  Possible values:
   *  - empty array indicates no type information for this expression
   *  - array with a single value contains a value of this expression
   *  - array with multiple values represents an intersetion type
   */
  type: string[];
  /** The updated method call info. */
  methodCall?: MethodCall;
  /** Profiling information about the expression. */
  profilingInfo: ProfilingInfo[];
  /** Whether the expression's value came from the cache. */
  fromCache: boolean;
  /** An extra information about the computed value. */
  payload: ExpressionUpdatePayload;
}

The ExpressionUpdate type information needs to be updated to carry the extra set of types of the multi-value and allow the IDE to find out what are the dispatch types and what are the extra types.

@4e6 4e6 self-assigned this Jan 27, 2025
@4e6 4e6 moved this from ❓New to 📤 Backlog in Issues Board Jan 27, 2025
@JaroslavTulach
Copy link
Member

FYI: #11600 (comment)

@4e6 4e6 moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 29, 2025
@enso-bot
Copy link

enso-bot bot commented Jan 29, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-01-27):

Progress: [cloud-v2][1651] Discussed possible implementations of the synchronization logic. Confirmed the short-term plan with the gui team. Started implementing the upload logic as a part of the project-manager shim middleware. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jan 29, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-01-28):

Progress: [cloud-v2][1651] Discussed downloading logic with Pavel. Negotiated a new API. Finished implementing the upload logic of the gui RemoteBackend. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jan 29, 2025

Dmitry Bushev reports a new STANDUP for today (2025-01-29):

Progress: [cloud-v2][1651] Implemented the upload handling in the gui project-manager middleware. Implemented the enso-project bundle creation. [12153] Implemented a new TypeInfo type representation as it is observed from the execution instrument. Starting updating the instrumentation logic It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jan 31, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-01-30):

Progress: [cloud-v2][1651] Added menu uption to run the cloud project locally. Implemented rough logic for downloading the project and spawning the local project manager. [12153] Updated the instrumentation logic. Started working on fixing the tests. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Jan 31, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-01-31):

Progress: [9976] Investigated the issue of failing uploads. Started moving the run script upload logic to the github actions upload-artifact. Updated the Engine and IDE workflows. Created a draft PR. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 3, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-02-01):

Progress: [9976] Fixed the issue with file permissions of project-manager bundle by creating a tar archive. Debugging an issue with generating multiline strings. Debugging an issue with mkdir on Windows. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 3, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-02-02):

Progress: [9976] Implemented uploading of final ide artifacts of the ide-packaging workflow. Testing the final artifacts. Removed outdated artifact downloading API and replaced it with the appropriate action. Testing the release workflow. Undrafted the PR. It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 3, 2025

Dmitry Bushev reports a new STANDUP for today (2025-02-03):

Progress: [9976] Implemented uploading of final ide artifacts on the release workflow. [12153] Fixed compilation of runtime tests. Debugging failing runtime server tests It should be finished by 2025-02-03.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 6, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-02-03):

Progress: [cloud-v2][1651] Finished implementing the Run Locally button and started testing. Fixed issues with the project downloading. Found a new issue with the missing project id of the downloaded cloud project. Started working on the fix It should be finished by 2025-02-10.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 6, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-02-04):

Progress: [cloud-v2][1651] Finished implementing the Run Locally button and started testing. Fixed issues with the project downloading. Found a new issue with the missing project id of the downloaded cloud project. Started working on the fix It should be finished by 2025-02-10.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 6, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-02-05):

Progress: [cloud-v2][1651] Updated the logic listing the directory to set missing project ids. Added listing directory logic to generate project id before starting the language server. Investigating the issue when the project is started, language server is running but the project tab does not open in the browser. It should be finished by 2025-02-10.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 6, 2025

Dmitry Bushev reports a new STANDUP for today (2025-02-06):

Progress: [12153] Finished fixing the runtime tests. Updated the language server protocol. Fixed the language server tests. Updated the runtime type info data structure according to the review comments. Undrafted the PR. It should be finished by 2025-02-10.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 7, 2025

Dmitry Bushev reports a new STANDUP for today (2025-02-07):

Progress: [12153] Updated the language server API. Fixed the PR review comments. Ready to merge when Windows CI is fixed. [cloud-v2][1651] Debugging the project opening. Simplified the logic and moved it to the context menu level. It should be finished by 2025-02-10.

Next Day: Next day I will be working on the #12153 task. Continue working on the task

@mergify mergify bot closed this as completed in #12195 Feb 10, 2025
@mergify mergify bot closed this as completed in 7d5bee6 Feb 10, 2025
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

2 participants