Skip to content

Commit

Permalink
Merge pull request #1598 from stackhouse-dev/refactor/ui
Browse files Browse the repository at this point in the history
Refactor/UI
  • Loading branch information
VanessaSirigu authored Jan 30, 2025
2 parents 0b1b88e + c3ecda1 commit 9ea8fb9
Show file tree
Hide file tree
Showing 10 changed files with 59 additions and 61 deletions.
6 changes: 3 additions & 3 deletions sass/common/Button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
outline: none;
}

.btn-primary,
.btn-primary:active,
.btn-primary:focus {
&.btn-primary,
&.btn-primary:active,
&.btn-primary:focus {
background-color: $color-brand-primary;
border: none;
}
Expand Down
14 changes: 4 additions & 10 deletions sass/component-repository/list/ComponentListActionsWrapper.scss
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@
width: fit-content;
}
}

.ComponentListActions__refresh-button {
color: #fff;
}
}

&__container-bundle-group {
Expand Down Expand Up @@ -122,14 +126,4 @@
}
}
}

//TO DO - refactor style
&__refresh-button {
background-color: $color-brand-primary;
color: white !important;
}

&__refresh-icon {
margin-left: 5px;
}
}
6 changes: 6 additions & 0 deletions sass/page-templates/common/PageTemplateForm.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
.PageTemplateForm {
padding-bottom: 20px;

.form-group {
margin-right: 0;
}

.FormLabel {
justify-content: flex-end;
}
Expand Down
25 changes: 13 additions & 12 deletions sass/pages/config/ContentPages.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,34 @@
border: 1px solid $color-content-07;
border-radius: $radius-xxs;

input{
input {
border: none;
color: $color-text-tertiary;
font-size: 14px;
height: 30px;
box-shadow: none;
//@TODO - container outline on focus


&::placeholder {
font-style: normal;
}
}

&:has(input:focus) {
box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075), 0 0 8px rgba(0, 136, 206, 0.6);

input:focus {
box-shadow: unset;
}
}
}

// sass-lint:disable no-important class-name-format force-element-nesting
&__pagetree-searchbtn.btn {
color: $color-text-tertiary;
border: none;
border-left: 1px solid $color-neutral-grey;
outline: none !important;
box-shadow: none !important;
background-color: $color-neutral-grey;
background: none;
height: 100%;
border-radius: $radius-xxs;
}
Expand Down Expand Up @@ -65,19 +71,16 @@

&__pagetree-addbtn {
background-color: $color-light-blue-2;
color: $color-primary-text;

// sass-lint:disable nesting-depth force-element-nesting
&:hover {
background-color: $color-light-blue-hover;
color: $color-primary-text;
}

&:focus,
&:focus:hover {
outline: none;
background-color: $color-light-blue-active;
color: $color-primary-text;
}
// sass-lint:enable nesting-depth force-element-nesting
}
Expand All @@ -101,8 +104,6 @@
&__search-table {
& .table {
margin-top: 0;
border: 1px solid $color-black;
color: $color-primary-text;
}

& thead,
Expand All @@ -113,13 +114,13 @@
& tr {
&.selected,
&:hover {
background-color: $color-dragitem-bg;
background-color: $color-dark-blue;
}
}

& th,
& td {
border: 1px solid $color-black !important;
border: none;
}

& .dropdown-kebab-pf .btn {
Expand Down
12 changes: 9 additions & 3 deletions sass/pages/list/PageListSearchTable.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
.PageListSearchTable {
.table-bordered {
border: $color-border-grey solid 1px;
border: none;
margin: 0;

tr {
border: 1px solid $color-border-grey;
}

th, td {
border: none;
}
}

.table-header {
Expand All @@ -20,13 +28,11 @@
padding: 16px;
border-left: 0;
border-right: 0;
border-color: $color-border-grey;
}
}

.table-row {
td {
border: 1px solid $color-border-grey;
border-left: 0;
border-right: 0;

Expand Down
1 change: 1 addition & 0 deletions sass/patternfly.scss
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ $fa-square-o: '\f096';
color: $color-text-tertiary !important;

&:hover, &:active, &:focus {
color: $color-brand-primary !important;
text-decoration: none;
}}
}
Expand Down
37 changes: 14 additions & 23 deletions sass/users/table/UserTable.scss
Original file line number Diff line number Diff line change
@@ -1,46 +1,26 @@
.UserTable {
margin: 0;

.UserTableWrapper {
width: 100%;
overflow-x: auto;
overflow-y: scroll;
max-height: 390px;
border-top: 1px solid $color-border-grey;
border-bottom: 1px solid $color-border-grey;

}

.table-bordered {
border: $color-border-grey solid 1px;
&.table-bordered {
border-color: $color-border-grey;
margin: 0;
}


.table-header {
background-color: #fff;

td {
border-left: 0;
border-right: 0;
}

.columnResizer {
border-bottom: 1px solid $color-border-grey;
}

th {
padding: 16px;
border-left: 0;
border-right: 0;
border-color: $color-border-grey;
}
}

.table-row {
td {
border: 1px solid $color-border-grey;
border-left: 0;
border-right: 0;
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
Expand All @@ -58,6 +38,17 @@ margin: 0;
padding: 16px;
border-left: 0;
border-right: 0;
border-color: $color-border-grey;
}
}

.UserTableWrapper {
width: 100%;
overflow-x: auto;
overflow-y: scroll;
max-height: 390px;

.content-view-pf-pagination {
border-color: $color-border-grey;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,10 @@ const ComponentListActionsWrapper = () => {
<ComponentListViewModeSwitcherContainer />
</div>
{ !isLocalRegistry && (
<Button // TO DO - style button
<Button
key="bundleRefetchButton"
// bsStyle="primary"
disabled={loading}
className="ComponentListActions__refresh-button primary"
className="ComponentListActions__refresh-button btn-primary"
onClick={handleRefreshBundles}
>
<FormattedMessage id="hub.bundle.refresh" />
Expand Down
4 changes: 1 addition & 3 deletions src/ui/fragments/list/FragmentGrid.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ class FragmentGrid extends Component {

return (
<div className="FragmentGrid__box">
<Col className="FragmentGrid__container" xs={12}>
<CardList list={fragments} actions={renderFragmentListMenuActions} />
</Col>
<CardList list={fragments} actions={renderFragmentListMenuActions} />
<PaginationRow
itemCount={totalItems}
itemsStart={itemsStart}
Expand Down
10 changes: 6 additions & 4 deletions src/ui/users/list/UserListTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ class UserListTable extends Component {
title: 'user.table.profileType',
field: 'profileType',
render: props => (
<Fragment>
{props.profileType.typeDescription}{' '}
<code>{props.profileType.typeCode}</code>
</Fragment>
props.profileType ?
<Fragment>
{props.profileType.typeDescription}
<code>{props.profileType.typeCode && props.profileType.typeCode}</code>
</Fragment>
: <Fragment />
),
},
{
Expand Down

0 comments on commit 9ea8fb9

Please sign in to comment.