Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message if three-letter sequence code haven't been recognized #2616

Closed
AlexeyGirin opened this issue Nov 6, 2024 · 1 comment · Fixed by #2629 or #2630
Closed

Wrong error message if three-letter sequence code haven't been recognized #2616

AlexeyGirin opened this issue Nov 6, 2024 · 1 comment · Fixed by #2629 or #2630
Labels
Bug Priority: Medium Sequence mode Bucket: Sequence mode related issues

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Nov 6, 2024

Steps to Reproduce

  1. Go to Macro - Flex mode
  2. Load using Paste from clipboard way: Ads
    image

Actual behavior
System throws an error: Unsupported symbols: Convert error! Given string could not be loaded as (query or plain) molecule or reaction, see the error messages
image

Expected behavior
System throws an error: Invalid Sequence: Given string cannot be interpreted as a valid three letter sequence.
image

As per requirement:

1.8. Every triplet of letters in the sequence (that has the first letter uppercase and others lowercase - requirement 1.6) should be interpreted as an amino acid using the table above.

1.9. If requirement 1.8. in not fulfilled an error message should appear, with a title "Invalid Sequence" and text "Given string cannot be interpreted as a valid three letter sequence."

AlaAsxAspAdsAsnArg is invalid because Ads does not correspond to any amino acid from the table above.

Versions

  • Ketcher Version 2.27.0-rc.1 Build at 2024-11-05; 14:55:18
  • Indigo Toolkit Version 1.26.0-rc.1.0-g904d2d992-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

Found while testing - epam/ketcher#5556, #2472

@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.27.0-rc.2 Build at 2024-11-12; 19:26:10
  • Indigo Toolkit Version 1.26.0-rc.2.0-gfec30ecd8-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.70 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment