Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Reach UI components with something maintained #1378

Closed
4 tasks done
millianapia opened this issue Nov 16, 2022 · 9 comments
Closed
4 tasks done

Replace Reach UI components with something maintained #1378

millianapia opened this issue Nov 16, 2022 · 9 comments
Assignees
Labels
♻️ Refactor 🛠 technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@millianapia
Copy link
Contributor

millianapia commented Nov 16, 2022

Reach UI is currently not maintained, they suggest using one of the following libraries instead:

  • Radix UI
  • Ariakit
  • React Aria

The following components needs to be refactored to a new library:

  • Accordion
  • Skip-nav
  • tabs
  • window-size
@fernandolucchesi
Copy link
Contributor

Hey @millianapia, left some comments in your commits =)

@millianapia
Copy link
Contributor Author

@fernandolucchesi have now refactored and fixed the UI changes after your recommendations :) ready to be reviewed again

@fernandolucchesi
Copy link
Contributor

Hi @millianapia , left a couple more comments :P

@millianapia
Copy link
Contributor Author

@fernandolucchesi fixed some things, added a couple of TODO and an explanation for the styling choices

@fernandolucchesi
Copy link
Contributor

@fernandolucchesi fixed some things, added a couple of TODO and an explanation for the styling choices

Nice! @millianapia I've replied to the thread about the stylings

@fernandolucchesi
Copy link
Contributor

Looks good!

@millianapia
Copy link
Contributor Author

Hi @meols @NickHaggerty1 , we have replaced a library that we used for a few components. There should not be any difference from your part, only from a code perspective. So the testcase is to check if these components are working like before:

  • Accordion
  • Tabs
  • Skip Nav/skip to content

Screenshot 2023-01-18 at 09 12 02

Screenshot 2023-01-18 at 09 12 46

Screenshot 2023-01-18 at 09 13 21

@millianapia
Copy link
Contributor Author

millianapia commented Jan 24, 2023

@meols @NickHaggerty1

@meols
Copy link
Collaborator

meols commented Jan 24, 2023

Works like before as far as I can see 👍 Thanks @millianapia

@millianapia millianapia changed the title Replace Reach UI with something maintained Replace Reach UI components with something maintained Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ Refactor 🛠 technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Development

No branches or pull requests

3 participants