Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projection information #6

Open
kcpevey opened this issue Jul 15, 2019 · 0 comments
Open

Projection information #6

kcpevey opened this issue Jul 15, 2019 · 0 comments

Comments

@kcpevey
Copy link
Collaborator

kcpevey commented Jul 15, 2019

There are currently several potential locations for projection storage in the adhModel object.

  • The adhmodel itself has a projection object.
  • The adhMesh object inside of the adhmodel obj has a projection object.

These need to be the same projection, but there is reasoning for each object holding its own specification.

Additionally, the adhmodel object inherits from the annotators which allows for specifying a crs on init which isn't stored but is propagated in the other elements.

Having the crs in so many places causes confusion in usage codes. This needs to be implemented in a smarter way, perhaps as a property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant