Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriangleTools.py removed #1026

Open
davidbrochart opened this issue Dec 5, 2019 · 2 comments
Open

TriangleTools.py removed #1026

davidbrochart opened this issue Dec 5, 2019 · 2 comments

Comments

@davidbrochart
Copy link
Contributor

There used to be an interface to Triangle in proteus/TriangleTools.py (see https://proteustoolkit.org/api/proteus.TriangleTools.html). The file is not present in master. Is it not supported any more?

@cekees
Copy link
Member

cekees commented Dec 5, 2019

That's correct. The license for triangle is problematic, and we decided to go the route of file-based interaction through the triangle CLI, as we do with tetgen for 3D meshes. I guess we need to clean up the docs and double check that we have all the functionality we need. /cc @tridelat

@tridelat
Copy link
Member

tridelat commented Dec 5, 2019

@davidbrochart @cekees yes those need to be removed manually so it can be hard to catch. As they were committed previously for the documentation, and even though these files are not (re)generated anymore when building the docs, they are still there and will appear on the website unless explicitly deleted first.
Btw, doc is probably going to move to https://github.com/erdc/proteus-doc at some point (rendered at https://erdc.github.io/proteus-doc/ ), which is a work in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants