You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Neither update the nodeDiametersArray or elementDiametersArray used in the computation of the Heaviside function.
Neither update the coefficient weighting in the point gauges, which would lead to inaccurate point gauge readings when the mesh is moved. Similar issues should arise when identifying segments for the line gauges.
Updating the node diameters is simple with a call to cmeshTools.computeGeometricInfo. Updating the gauges might wind up to be quite expensive (e.g. what if a point gauge now lies on a different element because of the mesh motion).
I'm putting this issue up to get some ideas, maybe have a discussion. I think that all these updates should occur during postStep of the MoveMesh model with the ability to influence the data structures/arrays in other models if necessary. There may also be a way to smartly update the structures used to obtain the local mesh entities of interest (e.g. k-d tree).
The text was updated successfully, but these errors were encountered:
…also included longer history for dt (needed for adaptivity) (#1182)
Referring to one of a few problems described in #1179. This PR is simply to get correctness in place. Later PRs will include tests based on a pseudo-adapted mesh.
Update for simplex meshes only in postStep()
There are a number of data structures that are not properly updated after a MoveMesh step.
postStep()
(https://github.com/erdc/proteus/blob/master/proteus/mprans/MoveMesh.py#L123) updates themesh.nodeArray
which stores the coordinates of the vertices.There is also a separate
updateAfterMeshMotion
function (https://github.com/erdc/proteus/blob/master/proteus/mprans/MoveMesh.py#L801) that is called before the next MoveMesh step, which seems to update the element and boundary quadrature fields.Neither update the
nodeDiametersArray
orelementDiametersArray
used in the computation of the Heaviside function.Neither update the coefficient weighting in the point gauges, which would lead to inaccurate point gauge readings when the mesh is moved. Similar issues should arise when identifying segments for the line gauges.
Updating the node diameters is simple with a call to
cmeshTools.computeGeometricInfo
. Updating the gauges might wind up to be quite expensive (e.g. what if a point gauge now lies on a different element because of the mesh motion).I'm putting this issue up to get some ideas, maybe have a discussion. I think that all these updates should occur during postStep of the MoveMesh model with the ability to influence the data structures/arrays in other models if necessary. There may also be a way to smartly update the structures used to obtain the local mesh entities of interest (e.g. k-d tree).
The text was updated successfully, but these errors were encountered: