New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stock - wannabe whole value? #12

Open

DanielOlewski opened this issue May 5, 2017 · 1 comment

DanielOlewski commented May 5, 2017 •

edited

Loading

= it's not doing its only responsibility well ... yet

no validation on constructor inputs
dates as strings
negative double values accepted

Contributor

wli3 commented May 14, 2017 •

edited

Loading

Agree, also stock.Ticker is being used a lot. If it is whole value, the field of it should not be accessed that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment