New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S: RefreshValues method does 5 things #7

Open

wli3 opened this issue May 2, 2017 · 0 comments

Contributor

wli3 commented May 2, 2017 •

edited

Loading

Where to fetch the data
find by code smell hard code string
https://github.com/ericgu/AnExerciseInCouplingDesRefWG/blob/master/StockTracker/Form1.cs#L36
How to fetch the data
find by code smell keyword new
https://github.com/ericgu/AnExerciseInCouplingDesRefWG/blob/master/StockTracker/Form1.cs#L39
fetch the data Form1 shouldn't contain the logic to fetch stock #3
https://github.com/ericgu/AnExerciseInCouplingDesRefWG/blob/master/StockTracker/Form1.cs#L40
parse the fetch result
https://github.com/ericgu/AnExerciseInCouplingDesRefWG/blob/master/StockTracker/Form1.cs#L43
format the result to human readable
find by the shape of the code?? 2 obvious separated block
https://github.com/ericgu/AnExerciseInCouplingDesRefWG/blob/master/StockTracker/Form1.cs#L60

every single concern could be a class

wli3 changed the title ~~S: RefreshValues method do too many things~~ S: RefreshValues method do 5 things

wli3 changed the title ~~S: RefreshValues method do 5 things~~ S: RefreshValues method does 5 things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment