-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap (beta) #1
Comments
I personally would say that it would be better to start from a fork and remove all unnecessary things piece by piece tbh As for me this fork should just be "an exact fork, but without the Node 4 support BS" |
Hi, the current maintainer of In my opinion, if we're going to do this, we should do it thoroughly. |
@SukkaW Can you elaborate on what deviations did happen in that fork? |
The most notable is that ljharb has hundreds of PRs piled up without reviewing or merging any of them. We want to backport many PRs to |
I see you've been active in the upstream |
yes, since the posting of this, jsx-a11y has stripped away all of the node compat stuff however, it likely still depends on the global mutation protection stuff (i.e. using a wrapped function for most built ins to avoid people mutating them and breaking the code). we likely don't need those in our case, so it may still be a good idea to create an alternative as they probably account for a lot of the dependency tree (Though I haven't checked, so please do if you get chance) |
@43081j I'm not sure which things you had in mind, but we did already remove usage of Next to that we also changed I'm happy to create extra PRs if you can explain what thing you would like to see changed as well |
It looks like the |
@ljharb Is it worth it to create PRs for updating these 2 libraries as well? Just so I know if it's worth my time spent updating these 2 libs Edit: @benmccann I've already created jsx-eslint/jsx-ast-utils#141 & jsx-eslint/jsx-ast-utils#142. Are there any other changes you would like to see in this library? |
safe-regex-test won’t be dropping anything, but jsx-ast-utils might, after the major bump, if it has no dependents left that need it. As for the PRs claim, the import plugin has 89 open PRs, and the vast majority have in fact been reviewed. I don’t think the hyperbole helps anyone. |
|
Yes, it still needs all those dependencies for the range of environments it’s intended for. |
as part of providing lighter alternatives for popular lint plugins with deep compat layers, this project should provide an alternative to the
jsx-a11y
plugin.At a high level, I don't think we should fork the plugin as it contains a large amount of support code for older runtimes and a plugin system we don't necessarily need.
Instead, we can do similar to lit-a11y - start from scratch but try to support the same rule set (as best we can / where appropriate).
The existing plugin's rules can be found here:
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y?tab=readme-ov-file#supported-rules
Basic requirements
Open questions
Contributors/Owners
I think we can start by contributing a rule each over time, and naturally will end up with a couple of us owning this repo (but anyone can contribute one).
I'll also start a discussion on discord (e18e) to discuss this
cc @MichaelDeBoey
The text was updated successfully, but these errors were encountered: