Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any plans for Rollbar reporter? #10

Closed
edbizarro opened this issue Apr 15, 2017 · 7 comments
Closed

Any plans for Rollbar reporter? #10

edbizarro opened this issue Apr 15, 2017 · 7 comments

Comments

@edbizarro
Copy link
Contributor

No description provided.

@esbenp
Copy link
Owner

esbenp commented Apr 16, 2017 •
edited
Loading

Sure, it would be fairly easy to add. Would you dare to take a crack at a PR? :-) You can just copy the sentry or bugsnag reporter and fit it to Rollbar

@edbizarro
Copy link
Contributor Author

yeah, I'll give it a shot :D

@edbizarro
Copy link
Contributor Author

done! #11

@esbenp
Copy link
Owner

esbenp commented Apr 17, 2017

Booom! #awesomesauce I will take a look :-)

@esbenp
Copy link
Owner

esbenp commented Apr 17, 2017

I just pushed #12 which changes the way reporters are instantiated. Can you add the rollbar reporter to the service provider as well?

@edbizarro
Copy link
Contributor Author

sure!

@esbenp
Copy link
Owner

esbenp commented Apr 17, 2017

Merged and released in 1.4.0! Thanks for your contribution @edbizarro this is awesome :-)

@esbenp esbenp closed this as completed Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edbizarro @esbenp