Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to import - many-keys-map | Old Pluto.jl exports #879

Open
pankgeorg opened this issue Sep 12, 2024 · 6 comments
Open

Failed to import - many-keys-map | Old Pluto.jl exports #879

pankgeorg opened this issue Sep 12, 2024 · 6 comments
Labels
browser Not working in Browser

Comments

@pankgeorg
Copy link

pankgeorg commented Sep 12, 2024

Failing module

import ManyKeysWeakMap from "https://cdn.esm.sh/v64/[email protected]/es2021/many-keys-weakmap.js"

Error message

After onload I got this:

GET https://esm.sh/v64/[email protected]/es2021/many-keys-weakmap.js net::ERR_ABORTED 500 (Internal Server Error)

Additional info

  • esm.sh version: 64
  • Browser version: Latest Chrome

crossref: fonsp/Pluto.jl#3019 and fonsp/Pluto.jl#2707
context:
Pluto HTML bundles that are on the internet and refer to ESM are more-or-less immutable, as they were usually built as part of some course that has now ended, so it's not maintained.

@pankgeorg pankgeorg added the browser Not working in Browser label Sep 12, 2024
@ije
Copy link
Member

ije commented Sep 12, 2024

@fonsp
Copy link

fonsp commented Sep 17, 2024

Hey! The problem in our project is that we version-pinned the esm.sh URL to future-proof the import. So we used

import ManyKeysWeakMap from "https://cdn.esm.sh/v64/[email protected]/es2021/many-keys-weakmap.js"

with the assumption that this would work forever, by pinning the esm.sh version, the package version and the compile target.

This import is baked into some archived html files that we generated in the past, and these files suddenly stopped working. Since this was an archival project, we can't change the import.

Is it possible to make the original import (with .js) work again, for versions where this worked in the past?

@fonsp
Copy link

fonsp commented Nov 13, 2024

Hi @ije, could you take a look at this?

@ije
Copy link
Member

ije commented Nov 13, 2024

@pankgeorg i will fix it asap! this is broken by https://github.com/esm-dev/esm.sh/releases/tag/v112

@ije ije mentioned this issue Nov 13, 2024
14 tasks
@ije
Copy link
Member

ije commented Nov 13, 2024

hi @fonsp, i just added a patch for the issue, now it works again https://esm.sh/v64/[email protected]/es2021/many-keys-weakmap.js

@fonsp
Copy link

fonsp commented Nov 13, 2024

Hey that's awesome, thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Not working in Browser
Projects
None yet
Development

No branches or pull requests

3 participants