Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Don't reboot after a failed update #10

Open
mweinelt opened this issue Aug 8, 2017 · 1 comment
Open

Don't reboot after a failed update #10

mweinelt opened this issue Aug 8, 2017 · 1 comment
Labels
bug

Comments

@mweinelt
Copy link
Contributor

mweinelt commented Aug 8, 2017 

192.168.110.13 - - [08/Aug/2017:20:30:51 +0200] "GET /firmware/sonoff.version HTTP/1.0" 301 178 "-" "-"
192.168.110.13 - - [08/Aug/2017:20:30:51 +0200] "GET /firmware/sonoff.rom1 HTTP/1.0" 301 178 "-" "-"

Oops, redirected to HTTPS - Esper cannot pull the upgrade file. Yet it still reboots. This shouldn't be happening!
@mweinelt mweinelt changed the title Reboot after failed update Don't reboot after a failed update Aug 9, 2017
@fooker fooker added the bug label Aug 22, 2017
@fooker
Copy link
Contributor

fooker commented Dec 12, 2017

Looks like the HTTP response code is not taken int account and the zero length body is written to the flash. As the zero length write is successfull, this will trigger a reboot. I will investigate if we can enhance the behavior of the updater or if fe need a upstream issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweinelt @fooker