Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add validate button to EDIT window? #188

Closed
poldim opened this issue Mar 2, 2019 · 1 comment
Closed

Can you add validate button to EDIT window? #188

poldim opened this issue Mar 2, 2019 · 1 comment

Comments

@poldim
Copy link
Contributor

poldim commented Mar 2, 2019

Just wondering if there is a way to add this functionality to initiate the validation process without leaving the edit page. It would be nice, since as a beginner with ESPHome, I find myself constantly editing and validating the yaml to try to solve issues.

I know there may be some challenges with having the validation process with the edit window open, but maybe the validating would run on-top-on the edit window. This way if the validation is unsuccessful, you get to see the results of why, and then you would click the normal close button to close the validation screen and be prompted with the edit screen. If the validation is successful, maybe you could present an upload button.

esphome dashboard 2019-03-02 14-19-00

@OttoWinter
Copy link
Member

See #162

And that would be nice, however I do not want to have a second modal pop up in front of the edit one. The whole dashboard needs to be redesigned a little to do this. Unfortunately I'm no web developer and do not have the time for that. Maybe someone else can tackle this

@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants