Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention #1

Open
apohllo opened this issue May 21, 2015 · 2 comments
Open

Naming convention #1

apohllo opened this issue May 21, 2015 · 2 comments

Comments

@apohllo
Copy link

apohllo commented May 21, 2015

Hi,

I looked into the code and it seems strange for me, that there are polish attributes in the classes. While I understand, that they come from the Sejmometr API, it seems more sensible to translate these attributes into English.

What you think about that?

@espresse
Copy link
Owner

Hi, you're right, they should be in English. To be honest I tried to translate them but I have failed due to some forgotten reasons. Do you want to help? :)

@apohllo
Copy link
Author

apohllo commented May 25, 2015

Well, we may use the names provided in the following file https://github.com/epforgpl/parldata-scrapers-poland-hungary-montenegro/blob/master/visegrad/spiders/mojepanstwo_pl.py

Yet I am not sure, if that make sense, since sejmometr no longer exist - at present it is called "mojepanstwo".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants