feat(lvgl_port): Update LVGL port for using button v4 (breaking change!) #500
Conversation
Test Results 17 files 17 suites 5m 52s ⏱️ Results for commit d3e75e7. ♻️ This comment has been updated with latest results. |
espzav
force-pushed
the
feat/lvgl_port_button_v4
branch
3 times, most recently
from
caf1058 to
39d97c8
Compare
espzav
force-pushed
the
feat/lvgl_port_button_v4
branch
2 times, most recently
from
a0f4228 to
232b4a8
Compare
|
@tore-espressif PTAL |
| #Get component button major version | ||
| string(REPLACE "." ";" BUTTON_VERSION_LIST ${button_ver}) | ||
| list(GET BUTTON_VERSION_LIST 0 button_ver_major) | ||
| target_compile_definitions(lvgl_port_lib PUBLIC "-DCOMPONENT_BUTTON_VERSION_MAJOR=${button_ver_major}") |
There was a problem hiding this comment.
The version define should come from the button component
So it should be BUTTON_VER_MAJOR. Could you please try it? It would help us avoid any convoluted CMake logic
There was a problem hiding this comment.
@tore-espressif What do you think about backward compatibility of BSP? Now, there is no breaking change of API, but it is not compatible with old button component. Should it be compatible with both?
Other BSPs will be updated in next PR.
There was a problem hiding this comment.
And CMake was changed and there was used BUTTON_VER_MAJOR. It is working. Thank you @tore-espressif :-)
espzav
force-pushed
the
feat/lvgl_port_button_v4
branch
from
232b4a8 to
3d1f29f
Compare
espzav
force-pushed
the
feat/lvgl_port_button_v4
branch
from
3d1f29f to
d3e75e7
Compare
ESP-BSP Pull Request checklist
Change description
Closes #494