Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate CancellableBufReader #2191

Open
kruss opened this issue Feb 5, 2025 · 1 comment · May be fixed by #2232
Open

Remove duplicate CancellableBufReader #2191

kruss opened this issue Feb 5, 2025 · 1 comment · May be fixed by #2232
Assignees
@kruss
Labels
new newly created issue

Comments

@kruss
Copy link
Collaborator

kruss commented Feb 5, 2025

The code for a CancellableBufReader is duplicated in:

application/apps/indexer/addons/text_grep/src/buffer.rs
application/apps/indexer/processor/src/search/buffer.rs
@kruss kruss self-assigned this Feb 5, 2025
@github-actions github-actions bot added the new newly created issue label Feb 5, 2025
This was referenced Feb 5, 2025
Merged
Closed
@kruss kruss closed this as completed Feb 7, 2025
@kruss kruss reopened this Feb 18, 2025
@kruss
Copy link
Collaborator Author

kruss commented Feb 18, 2025

Reopened as addons/text_grep cannot be removed (see: #2229)

kruss added a commit to kruss/chipmunk that referenced this issue Feb 18, 2025
@kruss
Remove duplicate CancellableBufReader (esrlabs#2191)
ab00ec8
@kruss kruss linked a pull request Feb 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kruss kruss

Labels
new newly created issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate CancellableBufReader kruss/chipmunk
Remove legacy text grep kruss/chipmunk
1 participant
@kruss