Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop: consolidate op-supervisor and op-geth types #12764

Open
protolambda opened this issue Oct 31, 2024 · 0 comments
Open

Interop: consolidate op-supervisor and op-geth types #12764

protolambda opened this issue Oct 31, 2024 · 0 comments

Comments

@protolambda
Copy link
Contributor

Op-geth contains an interoptypes package: https://github.com/ethereum-optimism/op-geth/tree/optimism/core/types/interoptypes
These types are a smaller subset of the op-supervisor types. Only what is needed to run the extract the dependencies from a list of log-events, and run the check-messages API.

The Identifier and SafetyLevel types are duplicate.

  • Identifier, can be moved into op-geth, and then in the op-supervisor types package we can set a Go type alias: type Identifier = interoptypes.Identifier
  • SafetyLevel could also be moved in the same way as the above, but maybe there's a more lean API we can use, that doesn't require a safety-level to be specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant