Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge script scripts/deploy/Deploy.s.sol:Deploy no longer works when rpc is specified #12915

Open
zhiqiangxu opened this issue Nov 13, 2024 · 2 comments

Comments

@zhiqiangxu
Copy link
Contributor

zhiqiangxu commented Nov 13, 2024

This is the command make devnet-up uses to generate L1 allocs(source):

DEPLOY_CONFIG_PATH=deploy-config/devnetL1-template.json forge script scripts/deploy/Deploy.s.sol:Deploy --sig "runWithStateDump()" "--sender" "0x90F79bf6EB2c4f870365E785982E1f101E93b906"

which works.

But if you also specify --rpc-url(sepolia in my case), it'll error out like this:

Image

@tynes
Copy link
Contributor

tynes commented Nov 14, 2024

You need to specify IMPL_SALT env var as a random bytes32

@zhiqiangxu
Copy link
Contributor Author

You need to specify IMPL_SALT env var as a random bytes32

It's already set in .envrc:

export IMPL_SALT=$(openssl rand -hex 32)

If I echo, it shows:

# echo $IMPL_SALT
789b62c5670c9712f7d2c763c5feed54a4128565a46cbb54602fd75b47968352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants