Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trace printing to prettyprinter #496

Open
arcz opened this issue Jun 21, 2024 · 2 comments
Open

Move trace printing to prettyprinter #496

arcz opened this issue Jun 21, 2024 · 2 comments
Labels
enhancement New feature or request good first issue

Comments

@arcz
Copy link
Collaborator

arcz commented Jun 21, 2024

Currently the traces are printed with hardcoded escape codes which makes it hard to show in brick UI (example). We should update showTrace to return a Doc structure and use ANSI terminal renderer to restore the current behavior. This will also make formatting traces a lot more flexible so we don't have to rewrite showTrace for each use case.

There are many pretty printing libraries in Haskell, here is some rationale for using prettyprinter.

@mahmudsudo
Copy link

hi, can i take on this ?

@msooseth
Copy link
Collaborator

msooseth commented Nov 8, 2024

@mahmudsudo of course, go take a shot at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue
Projects
None yet
Development

No branches or pull requests

3 participants