You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2018. It is now read-only.
I'm using pyethapp for two cross platform apps and noticed from the beginning the account creation and unlock was very slow. In fact this is a follow up from ethereum/pyethereum#750.
This is specially more annoying on smart device because it has less resources and the user has to wait for ages to unlock account to sign a transaction. Up to a point where I had to decrease the security by lowering the number of pbkdf2 iterations.
In fact the fix should be pretty straightforward since the new eth_keyfile.keyfile.create_keyfile_json() implementation is way more faster. So I guess we should "just" pull the dependency and switch to that one.
Use the new eth-keyfile module to encrypt/decrypt keyfile.
This makes it way faster to create and unlock accounts.
For instance with 100K PBKDF2 iteration rather than 100.
Running `pyethapp/tests/test_accounts.py` was outputing:
```
9 passed in 112.07 seconds
```
After the pull request it's now:
```
9 passed in 2.41 seconds
```
I'm using pyethapp for two cross platform apps and noticed from the beginning the account creation and unlock was very slow. In fact this is a follow up from ethereum/pyethereum#750.
This is specially more annoying on smart device because it has less resources and the user has to wait for ages to unlock account to sign a transaction. Up to a point where I had to decrease the security by lowering the number of pbkdf2 iterations.
In fact the fix should be pretty straightforward since the new eth_keyfile.keyfile.create_keyfile_json() implementation is way more faster. So I guess we should "just" pull the dependency and switch to that one.
Checklist
pyethapp
inside a virtualenvSystem/environment
Expected behaviour
Almost instant account creation on:
Observed behaviour
Just super slow.
Steps to reproduce
And cry 😢
The text was updated successfully, but these errors were encountered: