Use Django's system check framework instead of log message #153
Comments
|
That's not a bad shout. I'd take that PR. :) |
jnns
added a commit
to jnns/django-s3-storage
that referenced
this issue
Dec 9, 2022
This allows silencing the warning in case the user knows what they are doing. The check for AWS_S3_BUCKET_NAME is left untouched because it looks like even checks of level ERROR or CRITICAL can be silenced. Raising an exception seems like the better option to me. Closes etianen#153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using django-s3-storage together with Cloudflare R2 there are no public buckets. You'll need a so-called Worker to proxy the public requests to the private bucket.
In this setup, you'll need to set
AWS_S3_PUBLIC_URL = <your_worker_route>andAWS_S3_BUCKET_AUTH = True. This works perfectly fine but issues a warning each time a django-admin command is used:I'd like to silence this particular log message and it seems to me that Django's Sytem Check Framework would be the ideal use case for this scenario. SILENCED_SYSTEM_CHECKS could then be used to silence the check for those who don't need to be reminded of it.
If you agree that this would be useful, I'd write a patch for it.
The text was updated successfully, but these errors were encountered: