New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhenotypeResource enhancements #62

Open

arpost opened this issue Mar 17, 2016 · 0 comments

Contributor

arpost commented Mar 17, 2016

The GET endpoint is problematic because it requires the String key not the numerical id. There are two issues with this:

It doesn't follow the REST convention
keys are unique per user not globally unique (there is a uniqueness constraint in the database on ID + KEY)

So, I'd like the following changes:

Change the GET endpoint to require the numerical id to bring it into compliance with REST conventions
Create a new GET endpoint: /api/protected/users/{userid}/phenotypes/byname/{key} that requires a user id and a phenotype key.
Update eureka-webapp to use the new REST endpoint or the revised REST endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment